[webkit-reviews] review granted: [Bug 82658] Safari warns that it needs to resend the form in an iFrame when going back : [Attachment 140597] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 14:57:41 PDT 2012


Darin Adler <darin at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 82658: Safari warns that it needs to resend the form in an iFrame when
going back
https://bugs.webkit.org/show_bug.cgi?id=82658

Attachment 140597: Patch
https://bugs.webkit.org/attachment.cgi?id=140597&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140597&action=review


> Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:154
> +#if (USE(CFNETWORK) && !PLATFORM(WIN)) || (PLATFORM(MAC) &&
!defined(BUILDING_ON_SNOW_LEOPARD))

This whole file is already wrapped in #if USE(CFNETWORK), so there’s no reason
to check that.

The part of the predicate after the || is pointless because if !PLATFORM(WIN)
is true then it won’t even be evaluated.


More information about the webkit-reviews mailing list