[webkit-reviews] review denied: [Bug 85670] [BlackBerry] Implement a popup client for HTML controls : [Attachment 140589] updated patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 85670: [BlackBerry] Implement a popup client for HTML controls
https://bugs.webkit.org/show_bug.cgi?id=85670

Attachment 140589: updated patch
https://bugs.webkit.org/attachment.cgi?id=140589&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140589&action=review


Looks good, can still be cleaned up a bit.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:50
> +

Can remove the empty line.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:133
> +

Can remov the empty line here.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:233
> +    case WebCore::PlatformEvent::MouseReleased:

Can remove all WebCore:: prefixes in this method.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:252
> +    if (m_page) {

Can early return here if !page.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:258
> +    m_page.clear();

Better use m_page->clear();

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.h:24
> +

Can remove empty line here.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.h:54
> +

Ditto.