[webkit-reviews] review denied: [Bug 81490] Moving caret up or down skips lines when there's a non-editable line : [Attachment 140580] proposal patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 81490: Moving caret up or down skips lines when there's a non-editable line
https://bugs.webkit.org/show_bug.cgi?id=81490

Attachment 140580: proposal patch
https://bugs.webkit.org/attachment.cgi?id=140580&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140580&action=review


Thanks for tackling this bug but r- because we also need to fix
previousRootInlineBox and nextRootInlineBox.

As I have attempted, ideally, we would like to merge previousRootInlineBox and
nextRootInlineBox with code in previousLinePosition and nextLinePosition before
fixing this bug.

> LayoutTests/editing/selection/move-by-line-006-expected.txt:6
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS

Please make sure the test output shows what we're testing.