[webkit-reviews] review granted: [Bug 81854] RadioNodeList support in HTMLFormElement::elements : [Attachment 139868] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 81854: RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Attachment 139868: Updated patch
https://bugs.webkit.org/attachment.cgi?id=139868&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139868&action=review


> Source/WebCore/WebCore.xcodeproj/project.pbxproj:24860
> -				FD8C46EC154608E700A5910C /*
AudioScheduledSourceNode.h in Headers */,
> -				71A57DF2154BE25C0009D120 /* SVGPathUtilities.h
in Headers */,
> -				78D02BC6154A18DF00B62D05 /*
CSSPropertyAnimation.h in Headers */,
> -				FD629EA3154B47160006D026 /*
AudioBasicInspectorNode.h in Headers */,
> +		   FD8C46EC154608E700A5910C /* AudioScheduledSourceNode.h in
Headers */,
> +		   71A57DF2154BE25C0009D120 /* SVGPathUtilities.h in Headers
*/,
> +		   78D02BC6154A18DF00B62D05 /* CSSPropertyAnimation.h in
Headers */,
> +		   FD629EA3154B47160006D026 /* AudioBasicInspectorNode.h in
Headers */,
> +		   B658FFA21522EF3A00DD5595 /* JSRadioNodeList.h in Headers */,

> +		   B658FFA61522EFAA00DD5595 /* RadioNodeList.h in Headers */,

You should be using tabs instead of spaces here.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27879
> -				FD8C46EB154608E700A5910C /*
AudioScheduledSourceNode.cpp in Sources */,
> -				71A57DF1154BE25C0009D120 /*
SVGPathUtilities.cpp in Sources */,
> -				78D02BC5154A18DF00B62D05 /*
CSSPropertyAnimation.cpp in Sources */,
> -				FD629EA4154B47160006D026 /*
AudioBasicInspectorNode.cpp in Sources */,
> +		   FD8C46EB154608E700A5910C /* AudioScheduledSourceNode.cpp in
Sources */,
> +		   71A57DF1154BE25C0009D120 /* SVGPathUtilities.cpp in Sources
*/,
> +		   78D02BC5154A18DF00B62D05 /* CSSPropertyAnimation.cpp in
Sources */,
> +		   FD629EA4154B47160006D026 /* AudioBasicInspectorNode.cpp in
Sources */,
> +		   B658FFA11522EF3A00DD5595 /* JSRadioNodeList.cpp in Sources
*/,
> +		   B658FFA51522EFAA00DD5595 /* RadioNodeList.cpp in Sources */,


Ditto.

> Source/WebCore/html/RadioNodeList.cpp:52
> +static HTMLInputElement* toRadioButtonInputElement(Node* node)

You should add inline keyword here.