[webkit-reviews] review granted: [Bug 81004] [Chromium] Use GL_CHROMIUM_command_buffer_query to throttle texture uploads. : [Attachment 140549] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted David Reveman
<reveman at chromium.org>'s request for review:
Bug 81004: [Chromium] Use GL_CHROMIUM_command_buffer_query to throttle texture
uploads.
https://bugs.webkit.org/show_bug.cgi?id=81004

Attachment 140549: Patch
https://bugs.webkit.org/attachment.cgi?id=140549&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140549&action=review


R=me.  Thanks for all the changes.  I have a few more small nits, but nothing
major.

What's the status on the bug with command buffer queries that gman was going to
look into? Please make sure that is fixed before landing this.

> Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp:103
> +class FakeTextureUploader : public TextureUploader {

Please consolidate all these FakeTextureUploader classes.  Maybe just use the
common one?

> Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:978
> +    // Partail update of 4 tiles.

s/Partial/Partial/