[webkit-reviews] review denied: [Bug 23750] Cannot resize frames because frameborder=0 : [Attachment 140204] Patch to allow resize of frames even in case of frameborder=0. - III
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 7 11:27:36 PDT 2012
Eric Seidel <eric at webkit.org> has denied Swapna <spottabathini at innominds.com>'s
request for review:
Bug 23750: Cannot resize frames because frameborder=0
https://bugs.webkit.org/show_bug.cgi?id=23750
Attachment 140204: Patch to allow resize of frames even in case of
frameborder=0. - III
https://bugs.webkit.org/attachment.cgi?id=140204&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems reasonable to me. I wouldn't have used alerts for logging as they
make the test painful to use manually. You also seem to have a bunch of code
in your test case which is not executed. The code change is probably fine, but
the test case needs work.
More information about the webkit-reviews
mailing list