[webkit-reviews] review granted: [Bug 85760] [Chromium] Move fileSystem to Platform.h : [Attachment 140558] Patch with forwarding header

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 11:21:49 PDT 2012


Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85760: [Chromium] Move fileSystem to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85760

Attachment 140558: Patch with forwarding header
https://bugs.webkit.org/attachment.cgi?id=140558&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140558&action=review


> Source/WebKit/chromium/public/WebCommonWorkerClient.h:35
> -#include "platform/WebFileSystem.h"
> +#include <public/WebFileSystem.h>

I'd leave the includes in the API using the forwarding header in case not all
consumers of the API have their include paths set up to use the <public/...>
version.

> Source/WebKit/chromium/src/AssertMatchingEnums.cpp:107
> +#include <public/WebFileSystem.h>

Changing the includes in the cpp files (and the non-public h files) is good
though.


More information about the webkit-reviews mailing list