[webkit-reviews] review denied: [Bug 27577] [CSS3 Backgrounds and Borders] Add background-size to the background shorthand : [Attachment 140226] Patch-with-More-testCases

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis.menard at openbossa.org> has denied Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 27577: [CSS3 Backgrounds and Borders] Add background-size to the background
shorthand
https://bugs.webkit.org/show_bug.cgi?id=27577

Attachment 140226: Patch-with-More-testCases
https://bugs.webkit.org/attachment.cgi?id=140226&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140226&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2708
> +    RefPtr<CSSValueList> listOnOrAfterBackgroundSize =
CSSValueList::createSpaceSeparated();

The name is strange. what about backgroundSizeList.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2710
> +	   RefPtr<CSSValue> value =
getPropertyCSSValue(shorthand.properties()[i], DoNotUpdateLayout);

You don't need this for loop. Just call
getPropertyCSSValue(CSSPropertyBackgroundSize, DoNotUpdateLayout); what else
could be after the CSSPropertyBackgroundSize?