[webkit-reviews] review granted: [Bug 85805] Shrink SVGInlineTextBox object size : [Attachment 140541] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 85805: Shrink SVGInlineTextBox object size
https://bugs.webkit.org/show_bug.cgi?id=85805

Attachment 140541: Patch
https://bugs.webkit.org/attachment.cgi?id=140541&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140541&action=review


Where’s the compile-time size assertion for this class?

> Source/WebCore/rendering/svg/SVGInlineTextBox.h:86
> +    unsigned m_paintingResourceMode : 4;

When we add a new mode, what will point someone here to add more bits? I am
worried that this mode is defined in another file, and someone modifying it
would have no reason to look here. Maybe a comment in the file that defines the
enum?