[webkit-reviews] review denied: [Bug 84406] [DRT] LTC:: counterValueForElementById() could be moved to Internals : [Attachment 140520] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 84406: [DRT] LTC:: counterValueForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=84406

Attachment 140520: Patch
https://bugs.webkit.org/attachment.cgi?id=140520&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140520&action=review


Thanks for taking this on!

> Source/WebCore/testing/Internals.cpp:1011
> +String Internals::counterValueForElementById(String elementId)

This is not what we should do. Instead we should make an internals function
named counterValue that takes an element.

The only reason the old version worked with an ID was that it was easier to do
it that in DumpRenderTree at the time it was done.