[webkit-reviews] review canceled: [Bug 85760] [Chromium] Move fileSystem to Platform.h : [Attachment 140528] WIP patch (compile fails in WebFrame.h)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 10:26:44 PDT 2012


Adam Barth <abarth at webkit.org> has canceled Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85760: [Chromium] Move fileSystem to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85760

Attachment 140528: WIP patch (compile fails in WebFrame.h)
https://bugs.webkit.org/attachment.cgi?id=140528&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140528&action=review


> Source/WebKit/chromium/public/WebFrame.h:40
>  #include "platform/WebCanvas.h"
> -#include "platform/WebFileSystem.h"
>  #include "platform/WebReferrerPolicy.h"
>  #include "platform/WebURL.h"
> +#include <public/WebFileSystem.h>

The trick is to leave these includes the way they are and to add a "forwarding"
header like
<http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/public/platform/We
bURL.h>.  Once we've got everything in the right place, we'll remove the
forwarding headers, but for now they help prevent these sorts of compile
failures.


More information about the webkit-reviews mailing list