[webkit-reviews] review granted: [Bug 85728] [Cairo] Implement ImageBuffer::copyImage for BackingStoreCopy == DontCopyBackingStore : [Attachment 140420] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 85728: [Cairo] Implement ImageBuffer::copyImage for BackingStoreCopy ==
DontCopyBackingStore
https://bugs.webkit.org/show_bug.cgi?id=85728

Attachment 140420: Patch
https://bugs.webkit.org/attachment.cgi?id=140420&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140420&action=review


LGTM, just a small comment.

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:91
> +    return
BitmapImage::create(cairo_surface_reference(m_data.m_surface)).leakRef();

I don't think the leakRef here is correct because it would returning an Image
not an PassRefPtr<Image>, probably removing would be the right option.