[webkit-reviews] review granted: [Bug 84135] Support cross-filesystem operations in FileSystem API : [Attachment 140522] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 84135: Support cross-filesystem operations in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=84135

Attachment 140522: Patch
https://bugs.webkit.org/attachment.cgi?id=140522&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140522&action=review


> Source/WebCore/ChangeLog:24
> +	   - adding FileSystemType.h entry to build files (e.g. WebCore.gypi,
WebCore.xcodeproj etc)

Ok. I got through it. 

Perhaps there could have been a few other smaller pieces to break out but I
believe I reviewed this well as is.

Thanks for pulling out the pieces that you did because that made it easier!

> Source/WebKit/chromium/ChangeLog:68
> +2012-04-24  Kinuko Yasuda  <kinuko at chromium.org>

repeated entry.

> Source/WebCore/Modules/filesystem/chromium/DOMFileSystemChromium.cpp:116
> +    // filesystemName.toString();

Please remove this commented out line.