[webkit-reviews] review denied: [Bug 84697] [BlackBerry] Auth credentials set in private mode are reused in public mode. : [Attachment 140478] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Jason <jason.liu at torchmobile.com.cn>'s
request for review:
Bug 84697: [BlackBerry] Auth credentials set in private mode are reused in
public mode.
https://bugs.webkit.org/show_bug.cgi?id=84697

Attachment 140478: Patch
https://bugs.webkit.org/attachment.cgi?id=140478&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140478&action=review


Still some stuff to clean up.

> Source/WebCore/ChangeLog:10
> +	   Now, we only save credentials in memery and CredentialBackingStore
isn't enabled.

Typo memery -> memory

> Source/WebCore/ChangeLog:13
> +	   We have to change Private Browsering to test, so have to write a
manual test case.

Private Browsing.

> Source/WebCore/platform/network/CredentialStorage.cpp:162
> +void CredentialStorage::setPrivateMode(const bool mode)

No need for const bool.