[webkit-reviews] review denied: [Bug 85576] [BlackBerry] AutofillManager implementation upstream : [Attachment 140460] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 08:00:23 PDT 2012


Rob Buis <rwlbuis at gmail.com> has denied Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 85576: [BlackBerry] AutofillManager implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85576

Attachment 140460: Patch
https://bugs.webkit.org/attachment.cgi?id=140460&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140460&action=review


This can be cleaned up some more.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:26
> +class String;

Indent here, this is WebKit style.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:31
> +class WebPagePrivate;

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:37
> +class HTMLInputElement;

The whole block in namespace should be indented.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:50
> +    AutofillManager(BlackBerry::WebKit::WebPagePrivate*
page):m_webPagePrivate(page), m_element(0) { }

Watch the ':', it should have space characters around it.


More information about the webkit-reviews mailing list