[webkit-reviews] review requested: [Bug 84973] [GTK] Google tests that time out are leaked : [Attachment 140507] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 04:14:59 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 84973: [GTK] Google tests that time out are leaked
https://bugs.webkit.org/show_bug.cgi?id=84973

Attachment 140507: Patch
https://bugs.webkit.org/attachment.cgi?id=140507&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
This patch moves run-gtk-test to Tools/gtk directory renamed as run-api-tests.
Tools/Scripts/run-gtk-test is a simple wrapper that checks whether jhbuild is
available or not, so that it runs the whole script with jhbuild if present
(instead of running jhbuild for every subprocess of the script). In case of
using jhbuild, it uses the jhbuild-wrapper directly instead of run-with-jhbuild
to avoid another unnecessary layer.
run-api-tests has been simplified a lot, using common.py to get top_level and
build paths, and removing the _create_process helper used to run jhbuild. 
This change should be transparent for users of run-gtk-tests, so we don't need
any change in the bots.


More information about the webkit-reviews mailing list