[webkit-reviews] review denied: [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image. : [Attachment 140493] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dongwoo Joshua Im
<dw.im at samsung.com>'s request for review:
Bug 70304: width/height attributes of input element should be supported when
the type of the input element is image.
https://bugs.webkit.org/show_bug.cgi?id=70304

Attachment 140493: Patch
https://bugs.webkit.org/attachment.cgi?id=140493&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140493&action=review


>
LayoutTests/fast/forms/input-width-height-attributes-without-renderer-loaded-im
age.html:18
> +	   if (readyState == 'complete') {
> +	       shouldBe('e.width', '0');
> +	       shouldBe('e.height', '0');

The code says:
     // If the image is available, use its width.
      if (m_imageLoader->image())
	  return
m_imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).width();

e.width and e.height should not be 0, right?
You need to set display:none after completing the image loading.