[webkit-reviews] review denied: [Bug 85768] [Chromium] Move sharedWorkerRepository to Platform.h : [Attachment 140463] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85768: [Chromium] Move sharedWorkerRepository to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85768

Attachment 140463: Patch
https://bugs.webkit.org/attachment.cgi?id=140463&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140463&action=review


> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-63
> -class WebSharedWorkerRepository; // FIXME: Does this belong in platform?

This one is tricky because WebSharedWorkerRepository depends on
WebSharedWorker, which depends on a bunch of "non-platform" concepts (e.g.,
ScriptExecutionContext, ContentSecurityPolicy).  It's likely this will need to
move outside of the platform part of the API...  We'd need to look more closely
at where.