[webkit-reviews] review denied: [Bug 85766] [Chromium] Move createLocalStorageNamespace to Platform.h : [Attachment 140459] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 6 20:42:58 PDT 2012
Adam Barth <abarth at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85766: [Chromium] Move createLocalStorageNamespace to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85766
Attachment 140459: Patch
https://bugs.webkit.org/attachment.cgi?id=140459&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140459&action=review
> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-64
> -class WebStorageNamespace; // FIXME: Does this belong in platform?
Please move WebStorageNamespace.h and WebStorageArea.h at the same time. It
looks like there aren't any further dependencies, so that should work out fine.
We can then remove the FIXME comment because the answer seems to be "yes".
More information about the webkit-reviews
mailing list