[webkit-reviews] review denied: [Bug 85757] [Chromium] Move idbFactory to Platform.h : [Attachment 140448] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 6 20:29:29 PDT 2012


Adam Barth <abarth at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85757: [Chromium] Move idbFactory to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85757

Attachment 140448: Patch
https://bugs.webkit.org/attachment.cgi?id=140448&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebIDBFactory is a bit trickier.  Specifically, line 58 of
WebKitPlatformSupport.h says:

class WebIDBFactory; // FIXME: Does this belong in platform?

The trouble is that WebIDBFactory::getDatabaseNames depends on WebFrame. 
Source/Platform isn't allowed to know about Frames or WebFrames, so there's a
bit of untangling to do.


More information about the webkit-reviews mailing list