[webkit-reviews] review granted: [Bug 85751] Shrink TextRun object size : [Attachment 140442] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 85751: Shrink TextRun object size
https://bugs.webkit.org/show_bug.cgi?id=85751

Attachment 140442: Patch
https://bugs.webkit.org/attachment.cgi?id=140442&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140442&action=review


Can we add some compile time assertions to check if this is packed right, like
we normally do in cases like this?

>>> Source/WebCore/platform/graphics/TextRun.h:170
>>> +	 ExpansionBehavior m_expansionBehavior : 2;
>> 
>> Same problem as before.  MSVC will make the enum signed, and thus you'll
have one fewer bit than you think you do. :)  I thought we had helper macros
for this?
> 
> It is an unsigned in disguise!
> 
> typedef unsigned ExpansionBehavior;

Why not be explicit about it, given the likelihood of confusion?