[webkit-reviews] review denied: [Bug 85749] Update FeatureDefines.xcconfig files to list all ENABLE_ macros : [Attachment 140437] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 6 16:49:14 PDT 2012
Eric Seidel <eric at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 85749: Update FeatureDefines.xcconfig files to list all ENABLE_ macros
https://bugs.webkit.org/show_bug.cgi?id=85749
Attachment 140437: Patch
https://bugs.webkit.org/attachment.cgi?id=140437&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140437&action=review
> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:62
> +ENABLE_GESTURE_EVENTS = ;
I need to fix this. ENABLE_GESTURE_EVENTS should be on for Lion and above it
seems. This wouldn't break anything (due to the way Platform.h is written),
but it's still wrong.
More information about the webkit-reviews
mailing list