[webkit-reviews] review denied: [Bug 85751] Shrink TextRun object size : [Attachment 140442] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 6 16:12:35 PDT 2012
Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 85751: Shrink TextRun object size
https://bugs.webkit.org/show_bug.cgi?id=85751
Attachment 140442: Patch
https://bugs.webkit.org/attachment.cgi?id=140442&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140442&action=review
> Source/WebCore/platform/graphics/TextRun.h:170
> + ExpansionBehavior m_expansionBehavior : 2;
Same problem as before. MSVC will make the enum signed, and thus you'll have
one fewer bit than you think you do. :) I thought we had helper macros for
this?
More information about the webkit-reviews
mailing list