[webkit-reviews] review denied: [Bug 85751] Shrink TextRun object size : [Attachment 140440] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 6 15:49:01 PDT 2012


Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 85751: Shrink TextRun object size
https://bugs.webkit.org/show_bug.cgi?id=85751

Attachment 140440: Patch
https://bugs.webkit.org/attachment.cgi?id=140440&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140440&action=review


> Source/WebCore/platform/graphics/TextRun.h:170
> +    ExpansionBehavior m_expansionBehavior : 2;

bitfield enums will fail on MSVC (since they're signed).

> Source/WebCore/platform/graphics/TextRun.h:172
> +    TextDirection m_direction : 1;

Similar problem.


More information about the webkit-reviews mailing list