[webkit-reviews] review granted: [Bug 85741] Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code : [Attachment 140427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 6 11:41:14 PDT 2012


David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 85741: Cleanup: Change boolean synchronous flag argument into enum in
FileSystem API code
https://bugs.webkit.org/show_bug.cgi?id=85741

Attachment 140427: Patch
https://bugs.webkit.org/attachment.cgi?id=140427&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140427&action=review


> Source/WebCore/platform/FileSystemType.h:1
> +/*

I'm surprised that there aren't some build file changes to go along with this.

It would be nice to include it in build files. 

As long as this not being the those files doesn't break anything and it doesn't
seem to, I would be fine with that as a follow up patch -- In fact I made this
comment in the other patch so I'd land both and do one follow up patch for both
of them :) (but no rush on that follow up patch).


More information about the webkit-reviews mailing list