[webkit-reviews] review granted: [Bug 85714] Web Inspector: make JavaScriptSourceFrame use breakpoint manager's breakpoints store. : [Attachment 140407] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 5 23:49:36 PDT 2012
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 85714: Web Inspector: make JavaScriptSourceFrame use breakpoint manager's
breakpoints store.
https://bugs.webkit.org/show_bug.cgi?id=85714
Attachment 140407: Patch
https://bugs.webkit.org/attachment.cgi?id=140407&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140407&action=review
> Source/WebCore/ChangeLog:41
> + Web Inspector: do not create locations for resolved provisional
breakpoints
Revert this.
> Source/WebCore/inspector/front-end/BreakpointManager.js:168
> + breakpoints[i]._isProvisional = true;
Please revert this as it is a part of another change.
More information about the webkit-reviews
mailing list