[webkit-reviews] review granted: [Bug 85692] Convert isPageBoxVisible to use Internals interface : [Attachment 140397] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 85692: Convert isPageBoxVisible to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=85692

Attachment 140397: Patch
https://bugs.webkit.org/attachment.cgi?id=140397&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140397&action=review


> Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm:-315
> -    return [mainFrame isPageBoxVisible:pageNumber];

I can’t speak for the other ports, but for the Mac port, the isPageBoxVisible:
method exists only to support this DumpRenderTree feature. So we should also be
removing that method from WebKit entirely.