[webkit-reviews] review granted: [Bug 85641] KURL::isBlankURL would be a nicer idiom than KURL::protocolIs("about") : [Attachment 140374] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 5 12:45:00 PDT 2012


Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 85641: KURL::isBlankURL would be a nicer idiom than
KURL::protocolIs("about")
https://bugs.webkit.org/show_bug.cgi?id=85641

Attachment 140374: Patch
https://bugs.webkit.org/attachment.cgi?id=140374&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm surprised there aren't more of these.  For example, I would have expected
one in FrameLoader (or at least called from FrameLoader).  As for testing,
there's no way to test a change like this in WebKit.  WebKit typically uses
LayoutTests to test changes in web-visible behavior.  In this case there isn't
any external behavior change that we can test.	Thanks for the patch!


More information about the webkit-reviews mailing list