[webkit-reviews] review granted: [Bug 85697] webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT. : [Attachment 140381] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 5 10:56:04 PDT 2012
Eric Seidel <eric at webkit.org> has granted Raphael Kubo da Costa (rakuco)
<rakuco at webkit.org>'s request for review:
Bug 85697: webkitpy: Use os.pathsep instead of manually finding out the path
separator in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=85697
Attachment 140381: Patch
https://bugs.webkit.org/attachment.cgi?id=140381&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Yay! Except we really should have an os abstraction if this were unittested
code (which some day it should be). I believe FileSystem has .sep, so
presumably eventually our FileSystem class will have pathsep.
Since this is not currently really unittestable code, I won't make you move it.
But some day we should. :)
More information about the webkit-reviews
mailing list