[webkit-reviews] review granted: [Bug 85710] Web Inspector: convert standalone functions save/append/savedURL/appendedToURL into WebInspector.FileManager object. : [Attachment 140399] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 85710: Web Inspector: convert standalone functions
save/append/savedURL/appendedToURL into WebInspector.FileManager object.
https://bugs.webkit.org/show_bug.cgi?id=85710

Attachment 140399: Patch
https://bugs.webkit.org/attachment.cgi?id=140399&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140399&action=review


> Source/WebCore/inspector/front-end/HeapSnapshotView.js:872
> +	   return this._loaded && !this._savedChunksCount &&
WebInspector.fileManager.canAppendTo();

canAppendTo -> canAppend as there is no argument.

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:878
> +    _startWritingSnapshot: function(event)

I'd leave this function internal to save(), you should be able to remove it as
WebInspector.fileManager.removeEventListener(WebInspector.FileManager.EventType
s.SavedURL, startWritingSnapshot, this);

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:184
> +WebInspector.FileManager = function()

Move it to a separate file?