[webkit-reviews] review denied: [Bug 85703] Inline text boxes do not properly display long texts : [Attachment 140391] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 85703: Inline text boxes do not properly display long texts
https://bugs.webkit.org/show_bug.cgi?id=85703

Attachment 140391: Patch
https://bugs.webkit.org/attachment.cgi?id=140391&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140391&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:133
> +	   bool start = (state != RenderObject::SelectionEnd && startPos >=
m_start && startPos - m_start < (int)m_len);

Use static_cast instead.

> Source/WebCore/rendering/InlineTextBox.cpp:194
> +    bool respectHyphen = ePos == (int)m_len && hasHyphen();

Why did this change?

> Source/WebCore/rendering/InlineTextBox.cpp:1268
> +    ASSERT(offset - m_start <= (int)m_len);

static_cast

> Source/WebCore/rendering/InlineTextBox.h:169
> +    unsigned m_len;

Every bit in this struct counts, you can't simply bump the sizes here.