[webkit-reviews] review denied: [Bug 85624] Web Inspector: HTMLCanvasElement::didDraw instrumentation. : [Attachment 140233] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 85624: Web Inspector: HTMLCanvasElement::didDraw instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=85624

Attachment 140233: Patch
https://bugs.webkit.org/attachment.cgi?id=140233&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140233&action=review


> Source/WebCore/ChangeLog:8
> +	   Append record to timeline when drawing on HTML Canvas causes
invalidation,

Do you want a stack that caused repaint here? Why are you only interested in
canvas invalidations?

> Source/WebCore/html/HTMLCanvasElement.cpp:232
> +	   InspectorInstrumentation::didInvalidateRect(this->document(),
dirtyRect);

This is only a fraction of invalidations, a more specific name is needed. Also,
why do we want to instrument invalidation? Are you trying to trace the
subsequent paint from InspectorInstrumentation::willPaint to it?

> Source/WebCore/inspector/front-end/TimelineModel.js:82
> +    InvalidateRect: "InvalidateRect"

That's what is making the test fail, you should update the test.