[webkit-reviews] review granted: [Bug 85688] Rename ICULocale to LocaleICU, part 1 : [Attachment 140372] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 4 19:41:43 PDT 2012
Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 85688: Rename ICULocale to LocaleICU, part 1
https://bugs.webkit.org/show_bug.cgi?id=85688
Attachment 140372: Patch
https://bugs.webkit.org/attachment.cgi?id=140372&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review
> Source/WebCore/ChangeLog:8
> + Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}.
Nit: convention
> Source/WebCore/WebCore.gypi:4489
> + 'platform/text/LocaleICU.cpp',
> + 'platform/text/LocaleICU.h',
Nit: Alphabetical order please.
More information about the webkit-reviews
mailing list