[webkit-reviews] review denied: [Bug 85661] [BlackBerry] Add methods need by client side : [Attachment 140345] patch4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 19:12:48 PDT 2012


Antonio Gomes <tonikitoo at webkit.org> has denied Crystal Zhang
<haizhang at rim.com>'s request for review:
Bug 85661: [BlackBerry] Add methods need by client side
https://bugs.webkit.org/show_bug.cgi?id=85661

Attachment 140345: patch4
https://bugs.webkit.org/attachment.cgi?id=140345&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140345&action=review


patches does not apply against ToT!

> Source/WebKit/blackberry/Api/WebPageClient.h:254
> +    virtual void createPopupWebView(Platform::IntRect) = 0;

const Platform::IntRect& and please name the parameter, if it has a meaningful
name.


More information about the webkit-reviews mailing list