[webkit-reviews] review granted: [Bug 85236] Oscillator must implement noteOn() and noteOff() : [Attachment 139527] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 85236: Oscillator must implement noteOn() and noteOff()
https://bugs.webkit.org/show_bug.cgi?id=85236

Attachment 139527: Patch
https://bugs.webkit.org/attachment.cgi?id=139527&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139527&action=review


Looks good to me per your offline walkthrough of the code. r=me

> Source/WebCore/Modules/webaudio/Oscillator.cpp:211
> +	   outputBus->zero();

This is redundant; just return.