[webkit-reviews] review granted: [Bug 85584] Sort entries in FeaturesList.pm to make them easier to autogenerate : [Attachment 140166] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 14:28:51 PDT 2012


Daniel Bates <dbates at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 85584: Sort entries in FeaturesList.pm to make them easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85584

Attachment 140166: Patch
https://bugs.webkit.org/attachment.cgi?id=140166&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140166&action=review


> Tools/Scripts/webkitperl/FeatureList.pm:171
> +	 define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(),
value =>\$downloadAttributeSupport },

Nit: There should be a space character before the "\$downloadAttributeSupport".


> Tools/Scripts/webkitperl/FeatureList.pm:306
>      { option => "style-scoped", desc => "Toggle <style scoped> support",
>	 define => "ENABLE_STYLE_SCOPED", default => 0, value =>
\$styleScopedSupport },
>  
> +    { option => "sql-database", desc => "Toggle SQL Database Support",
> +	 define => "ENABLE_SQL_DATABASE", default => 1, value =>
\$sqlDatabaseSupport },

The order of these entries should be reversed since "sql-database" comes before
"style-scoped" in lexicographic order.


More information about the webkit-reviews mailing list