[webkit-reviews] review granted: [Bug 52994] WebKit should support tab-size. : [Attachment 121966] Updated test expectaiotns - smfr, hyatt: could you take another look?

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 52994: WebKit should support tab-size.
https://bugs.webkit.org/show_bug.cgi?id=52994

Attachment 121966: Updated test expectaiotns - smfr, hyatt: could you take
another look?
https://bugs.webkit.org/attachment.cgi?id=121966&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121966&action=review


> Source/WebCore/css/CSSParser.cpp:1890
> +	   validPrimitive = !id && validUnit(value, FInteger | FNonNeg, false);


Should tab-size:0 be allowed?

> Source/WebCore/platform/graphics/TextRun.h:115
> +    bool allowTabs() const { return 0 < m_tabSize; }

I think m_tabSize > 0 would be more readable.

> LayoutTests/fast/css/tab-size.html:27
> +    setupBlock("Default tab size (8).", null);
> +    setupBlock("Tab size = -10, should fall back to the default.",
"tab-size: -10;");
> +    setupBlock("Tab size = 2.", "tab-size: 2;");

Test tab-size: 0 too.