[webkit-reviews] review granted: [Bug 85414] [chromium] Show borders for partial-draw-culled quads to visualize culling behaviour : [Attachment 140291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 12:17:33 PDT 2012


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 85414: [chromium] Show borders for partial-draw-culled quads to visualize
culling behaviour
https://bugs.webkit.org/show_bug.cgi?id=85414

Attachment 140291: Patch
https://bugs.webkit.org/attachment.cgi?id=140291&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140291&action=review


R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.h:46
> +    void createCulledDebugBorderQuads(bool debug) {
m_createCulledDebugBorderQuads = debug; }

"create" here sounds like this function is doing something, rather than setting
a flag.  setCreateCulledDebugBorderQuads, maybe?


More information about the webkit-reviews mailing list