[webkit-reviews] review granted: [Bug 80996] [Qt] Add test specific platform plugin to achieve unified layout test results : [Attachment 138349] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 11:13:08 PDT 2012


Simon Hausmann <hausmann at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 80996: [Qt] Add test specific platform plugin to achieve unified layout
test results
https://bugs.webkit.org/show_bug.cgi?id=80996

Attachment 138349: updated patch
https://bugs.webkit.org/attachment.cgi?id=138349&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138349&action=review


r=me. Land with care :)

> Tools/DumpRenderTree/qt/main.cpp:132
> +static void initializeTestPlatformPlugin(int argc, char* argv[])

I suppose char* argv[] should be char* argv[] const? :)


More information about the webkit-reviews mailing list