[webkit-reviews] review granted: [Bug 85636] fix bit packing in FillLayer on Windows : [Attachment 140262] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 4 10:22:23 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 85636: fix bit packing in FillLayer on Windows
https://bugs.webkit.org/show_bug.cgi?id=85636
Attachment 140262: Patch
https://bugs.webkit.org/attachment.cgi?id=140262&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140262&action=review
> Source/WebCore/rendering/style/FillLayer.cpp:40
> +COMPILE_ASSERT(sizeof(FillLayer) == sizeof(SameSizeAsFillLayer),
FillLayer_should_not_grow);
I think we normally call these assertions FillLayer_should_stay_small. We
should probably get rid of underscores at some point...
More information about the webkit-reviews
mailing list