[webkit-reviews] review granted: [Bug 85230] Full screen will exit during a provisional load of a non-ancestor iframe. : [Attachment 140114] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 85230: Full screen will exit during a provisional load of a non-ancestor
iframe.
https://bugs.webkit.org/show_bug.cgi?id=85230

Attachment 140114: Patch
https://bugs.webkit.org/attachment.cgi?id=140114&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140114&action=review


> Source/WebKit/mac/ChangeLog:15
> +	   Move WebKitFullScreenListener into its own file:

Why mix this into the same patch with a bug fix? This obscures the question of
whether you made any code changes to WebKitFullScreenListener.

Why not move it into its own file separately, first?

> Source/WebKit/mac/WebView/WebView.mm:1858
> +	       WebKitFullScreenListener* listener = [[WebKitFullScreenListener
alloc] initWithElement:element];

The * is positioned wrong here.

> Source/WebKit/mac/WebView/WebView.mm:1863
> +	       WebFullScreenController* controller =
_private->newFullscreenController;
> +	       [controller close];

The * is positioned wrong here and I’m not sure why we’re using a local
variable here when we did not use one on the line above.