[webkit-reviews] review granted: [Bug 73039] Implement registration of WebIntents : [Attachment 140065] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 73039: Implement registration of WebIntents
https://bugs.webkit.org/show_bug.cgi?id=73039

Attachment 140065: Patch
https://bugs.webkit.org/attachment.cgi?id=140065&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140065&action=review


Thanks for taking the time to talk this over with the standards community.  I
also appreciate your using a separate ENABLE so that folks can enable both
halves separately.

> Source/WebCore/ChangeLog:7
> +

Please add some more information to the ChangeLog.  For example, in email you
told me about the state of standardization for <intent>.  That's good
information to include in the ChangeLog so folks following along at home can
know that we've done our due diligence.

> Source/WebCore/page/DOMWindow.idl:491
> +#if defined(ENABLE_WEB_INTENTS_TAG) && ENABLE_WEB_INTENTS_TAG
> +	   attribute HTMLIntentElementConstructor HTMLIntentElement;
> +#endif

You can just use the [Conditional] attribute.  See two lines above how that's
done for HTMLSourceElement.