[webkit-reviews] review granted: [Bug 85557] IndexedDB: Remove all index metadata records when deleting an index : [Attachment 140129] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 85557: IndexedDB: Remove all index metadata records when deleting an index
https://bugs.webkit.org/show_bug.cgi?id=85557

Attachment 140129: Patch
https://bugs.webkit.org/attachment.cgi?id=140129&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140129&action=review


> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests. Issues does not repro in DumpRenderTree.

Can you add a sentence or two explaining why you are making the change (hitting
an assert).  Please land a chromium side test after this gets rolled into
chromium.  You could maybe mention that here.

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:1093
> +    return encode(databaseId, objectStoreId, indexId, 255);

What is 255?  Should we make it a const somewhere?