[webkit-reviews] review granted: [Bug 85621] Web Inspector: use single method for retrieving evaluation context in the runtime agent : [Attachment 140220] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 07:32:51 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 85621: Web Inspector: use single method for retrieving evaluation context
in the runtime agent
https://bugs.webkit.org/show_bug.cgi?id=85621

Attachment 140220: Patch
https://bugs.webkit.org/attachment.cgi?id=140220&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140220&action=review


> Source/WebCore/inspector/PageRuntimeAgent.cpp:55
> +ScriptState* PageRuntimeAgent::getScriptStateForEval(ErrorString*
errorString, const String* frameId)

we don't use get prefixes in WebKit.


More information about the webkit-reviews mailing list