[webkit-reviews] review denied: [Bug 80788] Web Inspector: [chromium] ScriptGCEvent should not be static : [Attachment 140202] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 06:49:26 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 80788: Web Inspector: [chromium] ScriptGCEvent should not be static
https://bugs.webkit.org/show_bug.cgi?id=80788

Attachment 140202: Patch
https://bugs.webkit.org/attachment.cgi?id=140202&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140202&action=review


> Source/WebCore/bindings/v8/ScriptGCEvent.cpp:113
>      for (GCEventListeners::iterator i = listeners.begin(); i !=
listeners.end(); ++i)

Please get rid of this static list of listeners as all of the listeners will be
called for all GC events no matter in which isolate they happen.


More information about the webkit-reviews mailing list