[webkit-reviews] review requested: [Bug 85609] [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky : [Attachment 140212] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 06:38:12 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 85609: [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85609

Attachment 140212: Patch
https://bugs.webkit.org/attachment.cgi?id=140212&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
The issue was caused by the fact that
media/crash-closing-page-with-media-as-plugin-fallback.html and
media/video-poster-blocked-by-willsendrequest.html use the same PNG file as
poster attribute in the video tag. The PNG file gets cached when the first test
is executed and this somehow causes the second test to fail. I addressed this
by clearing the caches between the tests in
DumpRenderTreeChrome::resetDefaultsToConsistentValues().

The tests are no longer flaky.


More information about the webkit-reviews mailing list