[webkit-reviews] review granted: [Bug 85611] [Qt] Clean up and split features.prf into a static list of feature defaults : [Attachment 140197] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 85611: [Qt] Clean up and split features.prf into a static list of feature
defaults
https://bugs.webkit.org/show_bug.cgi?id=85611

Attachment 140197: Patch
https://bugs.webkit.org/attachment.cgi?id=140197&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140197&action=review


> Tools/qmake/mkspecs/features/features.prf:175
> +    haveQt(5): DEFINES += WTF_USE_GRAPHICS_SURFACE=1

Missing mac scope.

> Tools/qmake/mkspecs/features/features.prf:200
> +# Remove conflicting defines

Maybe comment that this is purely a cosmetic change to DEFINES to shorten the
command line.