[webkit-reviews] review granted: [Bug 85477] Web Inspector: createRawLocationByURL is too slow if a big number of evals happen. : [Attachment 140179] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 01:43:46 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 85477: Web Inspector: createRawLocationByURL is too slow if a big number of
evals happen.
https://bugs.webkit.org/show_bug.cgi?id=85477

Attachment 140179: Patch
https://bugs.webkit.org/attachment.cgi?id=140179&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140179&action=review


> Source/WebCore/inspector/front-end/DebuggerModel.js:337
> +		   scripts = {};

You never get a script by id from this map, why not use an array of scripts
instead?


More information about the webkit-reviews mailing list