[webkit-reviews] review requested: [Bug 79136] Hit testing may be incorrect with perspective transforms : [Attachment 140140] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 3 18:25:16 PDT 2012
Shawn Singh <shawnsingh at chromium.org> has asked for review:
Bug 79136: Hit testing may be incorrect with perspective transforms
https://bugs.webkit.org/show_bug.cgi?id=79136
Attachment 140140: Patch
https://bugs.webkit.org/attachment.cgi?id=140140&action=review
------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
There is one style issue about checking whether m33() == 0. If its OK, I would
prefer to keep it the way it is for readability, most of the rest of
TransformationMatrix.cpp already does that. Also, I tested all layout tests on
chromium, no obvious regressions. I tried to test Safari side layout tests
too, but so many tests are currently failing that its meaningless. However, I
still feel decently confident that this patch works as intended
More information about the webkit-reviews
mailing list