[webkit-reviews] review denied: [Bug 85509] Add htmlSource() in PagePopupClient : [Attachment 140044] updated patch, fix buid bug.

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 85509: Add htmlSource() in PagePopupClient
https://bugs.webkit.org/show_bug.cgi?id=85509

Attachment 140044: updated patch, fix buid bug.
https://bugs.webkit.org/attachment.cgi?id=140044&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140044&action=review


> Source/WebCore/page/PagePopupClient.h:63
> +    // This is called when load the content HTML
> +    virtual String htmlSource() { return String(); }

Why do we need this though we already have writeDocument(DocumentWriter&)?
Which should a PagePopupClient implementation provide? Which should a PagePopup
implementation call?

ChangeLog should have such information.